Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Synology storage backend implementation in sunbeam-python, along with unit tests and updates to the shared backend test fixtures to include the new backend.
Changes:
- Add
SynologyBackend+SynologyConfig(Pydantic model) undersunbeam.storage.backends.synology. - Add unit tests validating backend identity, config fields, secret-field marking, and protocol validation.
- Extend common backend tests/fixtures to include Synology in the “all backends” suite.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/synology/backend.py | Adds the Synology backend class and its configuration model. |
| sunbeam-python/sunbeam/storage/backends/synology/init.py | Declares the new backend package. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_synology.py | Adds Synology-specific unit tests (backend + config validation). |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds synology_backend fixture and includes it in the parametrized any_backend. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Updates common uniqueness/expectation tests to include Synology. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-synology-charm
branch
from
94ddd51 to
4868c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984525